Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(mui): added initialValue to the list of excluded props #1475

Conversation

mdomarus
Copy link
Contributor

Description

On multiselect initialValue was passed to the span element resulting in console errors.

Checklist: (please see documentation page for more information)

  • [✅] Yarn build passes
  • [✅] Yarn lint passes
  • [✅] Yarn test passes
  • Test coverage for new code (if applicable)
  • Documentation update (if applicable)
  • [✅] Correct commit message
    • format fix|feat({scope}): {description}
    • i.e. fix(pf3): wizard correctly handles next button
    • fix will release a new _._.X version
    • feat will release a new _.X._ version (use when you introduce new features)
      • we want to avoid any breaking changes, please contact us, if there is no way how to avoid them
    • scope: package
    • if you update the documentation or tests, do not use this format
      • i.e. Fix button on documenation example page

Copy link

vercel bot commented Jul 10, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-forms ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 10, 2024 10:34am

Copy link

codecov bot commented Jul 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.49%. Comparing base (83a4737) to head (acfb9cc).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1475   +/-   ##
=======================================
  Coverage   94.49%   94.49%           
=======================================
  Files         210      210           
  Lines        3975     3975           
  Branches     1629     1629           
=======================================
  Hits         3756     3756           
  Misses        219      219           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Hyperkid123 Hyperkid123 merged commit dac8b99 into data-driven-forms:master Jul 10, 2024
6 checks passed
@rvsia rvsia added the released label Jul 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants