Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dependency on package:intl #589

Merged
merged 3 commits into from
Sep 23, 2024
Merged

Remove dependency on package:intl #589

merged 3 commits into from
Sep 23, 2024

Conversation

mosuem
Copy link
Member

@mosuem mosuem commented Sep 23, 2024

As I assume the datetime strings need not be localized. If they should be, then ignore this PR, and we should change the documentation instead.


  • I’ve reviewed the contributor guide and applied the relevant portions to this PR.
Contribution guidelines:

Note that many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.

Copy link

github-actions bot commented Sep 23, 2024

PR Health

Breaking changes ✔️
Package Change Current Version New Version Needed Version Looking good?
unified_analytics Non-Breaking 6.1.3 6.1.4-wip 6.1.4 ✔️
Changelog Entry ✔️
Package Changed Files

Changes to files need to be accounted for in their respective changelogs.

Coverage ⚠️
File Coverage
pkgs/unified_analytics/lib/src/analytics.dart 💚 72 %
pkgs/unified_analytics/lib/src/config_handler.dart 💚 94 %
pkgs/unified_analytics/lib/src/constants.dart 💔 Not covered
pkgs/unified_analytics/lib/src/utils.dart 💚 88 %

This check for test coverage is informational (issues shown here will not fail the PR).

This check can be disabled by tagging the PR with skip-coverage-check.

API leaks ⚠️

The following packages contain symbols visible in the public API, but not exported by the library. Export these symbols or remove them from your publicly visible API.

Package Leaked API symbols
unified_analytics Condition
PersistedSurvey
GAClient
UserProperty

This check can be disabled by tagging the PR with skip-leaking-check.

License Headers ✔️
// Copyright (c) 2024, the Dart project authors. Please see the AUTHORS file
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.
Files
no missing headers

All source files should start with a license header.

Package publish validation ✔️
Package Version Status
package:cli_config 0.2.1-wip WIP (no publish necessary)
package:coverage 1.9.2 already published at pub.dev
package:extension_discovery 2.0.1-wip WIP (no publish necessary)
package:graphs 2.3.3-wip WIP (no publish necessary)
package:mime 2.0.0-wip WIP (no publish necessary)
package:oauth2 2.0.4-wip WIP (no publish necessary)
package:source_map_stack_trace 2.1.3-wip WIP (no publish necessary)
package:unified_analytics 6.1.4-wip WIP (no publish necessary)

Documentation at https://github.com/dart-lang/ecosystem/wiki/Publishing-automation.

@@ -2,19 +2,21 @@ name: unified_analytics
description: >-
A package for logging analytics for all Dart and Flutter related tooling
to Google Analytics.
# LINT.IfChange
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there tooling supporting these style comments?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, not yet (I see this as a feature request to the PR health bot ;) )

I wrote this just for more visual noise, as I overlooked this at first and thought this might help with this not happening again.

@mosuem mosuem merged commit e1d8dbe into main Sep 23, 2024
14 checks passed
@mosuem mosuem deleted the removeIntlDep branch September 23, 2024 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants