Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimize replacing user mentions in messages #24

Open
danvratil opened this issue Dec 20, 2020 · 0 comments
Open

Optimize replacing user mentions in messages #24

danvratil opened this issue Dec 20, 2020 · 0 comments
Labels
performance

Comments

@danvratil
Copy link
Owner

Right now the code in MessageFormatter::replaceUserInfo() tries to match IDs of all known users against the message and replace, which is very expensive in large workspaces.

Instead the regex should match all ID-like patterns, find matching user and replace it.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
performance
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@danvratil