Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chartHeight calculation formula #3

Open
JojiKoike opened this issue Dec 4, 2018 · 2 comments
Open

chartHeight calculation formula #3

JojiKoike opened this issue Dec 4, 2018 · 2 comments

Comments

@JojiKoike
Copy link

In multi-line-chart.ts line 70,
const chartHeight = height - margin.left - margin.right;

I think
const chartHeight = height - margin.top - margin.bottom;
is correct , isn't it?

Thanks and regards.
@dang1412
Copy link
Owner

dang1412 commented Dec 4, 2018

Oh you are right, thank you very much :)

@JojiKoike
Copy link
Author

That's ok, thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@JojiKoike @dang1412