Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pushing to Docker-Hub is triggerd by timmer and not content #17

Open
2 tasks
uCatu opened this issue Jul 9, 2020 · 2 comments
Open
2 tasks

Pushing to Docker-Hub is triggerd by timmer and not content #17

uCatu opened this issue Jul 9, 2020 · 2 comments

Comments

@uCatu
Copy link
Contributor

uCatu commented Jul 9, 2020

Pushing on daily timmer is creating overhead and confusion image timestamp is updated without any phsyical channge.

triggeredBy 'TimerTrigger'

Suggestio:

  • trigge by tag which is a manual action that developer need to remeber
    when { buildingTag() }

Or

  • trigger by SCM SHA code change detection, completely automatic, but can cause commits the be public as soon as push instead of aggregated into version.
  • Need to investigate behavior on Jenkins build replay or just triggering build and when we do git rebase
@sashaCher
Copy link
Contributor

I guess that the decision of to push to DockerHub or not to push should be a function of the next inputs:
One of the Dockerfiles of build.sh scripts has changed from the last time triggered build
or
Base Ubuntu or Phusion image has been updated from the last time triggered build

The first one will validate that we're pushing only when valuable changes have been made in image build content/process.
The second one will validate that we're up to date with latests Ubuntu/Phusion changes and do not miss any security upgrade.

In addition we should publish date tag. It will allow to roll back to specific date tag in case and we harm latest.

@uCatu
Copy link
Contributor Author

uCatu commented Jul 12, 2020

@sashaCher There is a caveat that we need to pay attention to - If we will push on changes (Dockerfiles or Base iamge) we leave no time to check master correctness before release. Some feature might require us to accumulate commits before releaseing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

2 participants