-
-
Notifications
You must be signed in to change notification settings - Fork 6
Works to be continued for Styling
cyfung1031 edited this page Dec 21, 2022
·
7 revisions
Genius Themes
- Native Theme - obsolete
- Native Theme + React (
desktop_react
) - Majority - Native Theme + React + Primis (
desktop_react_atf
) - cookie based
The styling used in this Userscript
- Genius React (
geniusReact
) - Genius React with Primis (
geniusReactPrimis?
) - Clean White (
cleanwhite
) - Spotify (
spotify
)
To make them easier to use & read & adapt further changes, we must do some coding reviews!!
- Dig out the common coding among themes and make colors and styles with pure CSS only.
display:none
instead of DOM removal - Try to normalize the CSS rules to adopt both
desktop_react
anddesktop_react_atf
. (ClassNamesssss) - Try to normalize the CSS coloring so that common CSSs can be used and just change few CSS for various styles. Using_CSS_custom_properties
- Consider Genius React shall be the base design and on top of it to develop
cleanwhite
andspotify
; This must be done by CSS rules.
Related Issues:
- Genius Lyrics #18 - Styles & Coding
- Genius Lyrics #15 - AutoScrolling
- Genius Lyrics #37 - WithPrimis
Note:
- Do not use
:has(...)
!! -
content-visibility
alone is not preferred.