fix(eventtemplates): log warning and continue if declarative Event Template already exists #726
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 27, 2024
Josh-Matsuoka
approved these changes
Nov 28, 2024
…mplate already exists
andrewazores
force-pushed
the
event-template-declarative
branch
from
ecfc143
to
cb448c1
Compare
|
/build_test |
|
Workflow started at 11/28/2024, 3:08:52 PM. View Actions Run. |
|
No GraphQL schema changes detected. |
|
No OpenAPI schema changes detected. |
|
CI build and push: All tests pass ✅ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Welcome to Cryostat! 👋
Before contributing, make sure you have:
mainbranch[chore, ci, docs, feat, fix, test]To recreate commits with GPG signature
git fetch upstream && git rebase --force --gpg-sign upstream/mainRelated to #718
Description of the change:
Tolerate already existing Event Templates when loading from container filesystem at startup.
Motivation for the change:
Declarative configurations for Event Templates (ie defining them by mounting files to the container, ex. by Operator CR linking to ConfigMaps) should be tolerant of the templates already existing, since they will already exist in the remote S3 storage service if the Cryostat container has been restarted, for example.
How to manually test:
oc rollout restart deployment cryostat-v4to trigger the case where the template already exists in storage. With this PR, Cryostat should log a warning and continue. Without this PR, Cryostat will not catch the exception and will fail startup, leading to a container restart loop.