Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(strings): update 2.4 user-facing strings #1155

Merged
merged 2 commits into from
Nov 2, 2023

Conversation

mwangggg
Copy link
Member

@mwangggg mwangggg commented Nov 1, 2023

Welcome to Cryostat! 👋

Before contributing, make sure you have:

  • Read the contributing guidelines
  • Linked a relevant issue which this PR resolves
  • Linked any other relevant issues, PR's, or documentation, if any
  • Resolved all conflicts, if any
  • Rebased your branch PR on top of the latest upstream main branch
  • Attached at least one of the following labels to the PR: [chore, ci, docs, feat, fix, test]
  • Signed all commits using a GPG signature

To recreate commits with GPG signature git fetch upstream && git rebase --force --gpg-sign upstream/main


Related to: https://github.com/cryostatio/cryostat/issues/1695

@mergify mergify bot added the safe-to-test label Nov 1, 2023
@mwangggg mwangggg added the chore Refactor, rename, cleanup, etc. label Nov 1, 2023
@mwangggg mwangggg marked this pull request as ready for review November 2, 2023 17:26
locales/en/public.json Outdated Show resolved Hide resolved
@andrewazores
Copy link
Member

Do you have any other strings to update, and if so do you want to include them in this PR or separately?

@mwangggg
Copy link
Member Author

mwangggg commented Nov 2, 2023

These are the last two strings that haven't been updated from the 2.3 spreadsheet- I'll update others in a separate PR after the documentation team looks at them

@andrewazores andrewazores merged commit 6fcf52a into cryostatio:main Nov 2, 2023
21 checks passed
mergify bot pushed a commit that referenced this pull request Nov 2, 2023
andrewazores pushed a commit that referenced this pull request Nov 2, 2023
(cherry picked from commit 6fcf52a)

Co-authored-by: Ming Yu Wang <90855268+mwangggg@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport chore Refactor, rename, cleanup, etc. safe-to-test
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants