Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Task] Update CI badge #631

Closed
tthvo opened this issue Sep 20, 2023 · 3 comments · Fixed by #633
Closed

[Task] Update CI badge #631

tthvo opened this issue Sep 20, 2023 · 3 comments · Fixed by #633
Assignees
@733amir
Labels
docs good first issue Good for newcomers

Comments

@tthvo
Copy link
Member

tthvo commented Sep 20, 2023

After #619, the CI badge is broken.

image
@tthvo tthvo added good first issue Good for newcomers docs labels Sep 20, 2023
@tthvo tthvo moved this to Todo in 2.4.0 release Sep 20, 2023
@tthvo
Copy link
Member Author

tthvo commented Sep 20, 2023 •
edited
Loading

Now that test and quay build/push are separated. We should have 2 badges for test and build/push.

Something like https://github.com/quarkusio/quarkus. They have a badge for maven artifacts. We can explore an option for quay image.

@733amir
Copy link
Contributor

733amir commented Sep 21, 2023

@tthvo We only need to update the link from ci.yml to build-ci.yml? 🤔

@tthvo
Copy link
Member Author

tthvo commented Sep 21, 2023

Right! We also want to have the test status. That should be test-ci-push.yaml

@733amir 733amir mentioned this issue Sep 24, 2023
Merged
@github-project-automation github-project-automation bot moved this from Todo to Done in 2.4.0 release Sep 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@733amir 733amir

Labels
docs good first issue Good for newcomers
Projects
No open projects
2.4.0 release
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

docs(readme): build-ci and test-ci-push badges 733amir/cryostat-operator
2 participants
@733amir @tthvo