Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(strings): Cryostat 2.4 user-facing strings fixes #1758

Closed
wants to merge 1 commit into from
Closed

chore(strings): Cryostat 2.4 user-facing strings fixes #1758

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/main/java/io/cryostat/net/PermissionDeniedException.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ public PermissionDeniedException(
String namespace, String resource, String verb, String reason) {
super(
String.format(
"Requesting client in namespace \"%s\" cannot %s %s: %s",
"Requested client in namespace \"%s\" cannot %s %s: %s",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this one actually should be "Requesting", or maybe another word entirely. What this is logging is that some API client (user) asked to perform some action, and Cryostat determined that this user does not have sufficient permissions to do what they had asked.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll close this PR for now then.

namespace, verb, resource, reason));
this.namespace = namespace;
this.resource = resource;
Expand Down
Loading