Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export settings issue #247

Open
AndrewStoyan opened this issue Sep 13, 2024 · 1 comment
Open

Export settings issue #247

AndrewStoyan opened this issue Sep 13, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@AndrewStoyan
Copy link

AndrewStoyan commented Sep 13, 2024

Is your feature request related to a problem? Please describe.

Export options in the action config are partially ignored. If you specify skip_untranslated_strings, skip_untranslated_files, or export_only_approved as true, they work fine, overriding the project export settings.

However, if you specify them as false, they are ignored and the project settings are used.

Describe the solution you'd like

In my opinion, the expected behavior should also override the export options when they are set to false.

@AndrewStoyan AndrewStoyan added the enhancement New feature or request label Sep 13, 2024
@joshuatbrown
Copy link

Oh wow -- I didn't realize this was why the action wasn't working for me. Thanks for reporting this! Hope the issue is addressed!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants