Skip to content
This repository has been archived by the owner on Jul 4, 2024. It is now read-only.

Add -cppcoreguidelines-avoid-do-while #61

Merged
merged 1 commit into from
Oct 14, 2023

Conversation

tim77
Copy link
Contributor

@tim77 tim77 commented Oct 14, 2023

@Shatur Shatur enabled auto-merge (squash) October 14, 2023 12:13
@Shatur Shatur changed the title ci(.clang-tidy): Add -cppcoreguidelines-avoid-do-while Add -cppcoreguidelines-avoid-do-while Oct 14, 2023
@Shatur
Copy link
Member

Shatur commented Oct 14, 2023

Thanks!
Conventional commits are nice, probably worth considering switching in the future. But until now I renamed the PR.

While you are at it, could you take a look at #60? An easy change.

@tim77
Copy link
Contributor Author

tim77 commented Oct 14, 2023

Conventional commits are nice, probably worth considering switching in the future. But until now I renamed the PR.

I was in a hurry again, sorry. Should I also rename the commit to Add -cppcoreguidelines-avoid-do-while?

While you are at it, could you take a look at #60? An easy change.

🔜

@Shatur
Copy link
Member

Shatur commented Oct 14, 2023

I was in a hurry again, sorry. Should I also rename the commit to Add -cppcoreguidelines-avoid-do-while?

No need, I renamed it on auto squash merge. I like conventional commit names, but this project currently don't use it, so I renamed it for consistency.

@Shatur Shatur merged commit f36e073 into crow-translate:master Oct 14, 2023
4 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants