Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add eslint to lint app.js #11

Open
cyberhck opened this issue Dec 4, 2017 · 1 comment
Open

add eslint to lint app.js #11

cyberhck opened this issue Dec 4, 2017 · 1 comment
Milestone

Comments

@cyberhck
Copy link

cyberhck commented Dec 4, 2017

Right now I can see a lot of inconsistencies on code style, it's a minor (but important) thing, we should at least lint app.js for code styles.

Doing that should be fairly simple, just npm init, npm i eslint -D, ./node_modules/.bin/eslint --init (not sure about this one, it's similar), then using a code style (preferably google's) should be good.

We could add this to .travis as well.

thoughts? @Solomonic @lalita13008

@wmathes
Copy link

wmathes commented Dec 4, 2017

if we do this, we might as well switch to TypeScript. Not urgent for now :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants