From 195b9ac516e58839b4d63c4e3f7662c2d9d41379 Mon Sep 17 00:00:00 2001 From: Louis Bompart Date: Mon, 18 Nov 2024 18:07:09 -0500 Subject: [PATCH] chore: synchronize type-react dependencies (#4659) https://coveord.atlassian.net/browse/KIT-3701 --- package-lock.json | 54 ++----------------- .../components/providers/listing-provider.tsx | 6 +-- .../components/providers/search-provider.tsx | 8 +-- .../headless-ssr-commerce/package.json | 4 +- packages/samples/headless-ssr/package.json | 4 +- 5 files changed, 12 insertions(+), 64 deletions(-) diff --git a/package-lock.json b/package-lock.json index 556263d06d8..b47382cc3aa 100644 --- a/package-lock.json +++ b/package-lock.json @@ -21024,12 +21024,6 @@ "dev": true, "license": "MIT" }, - "node_modules/@types/scheduler": { - "version": "0.16.8", - "resolved": "https://registry.npmjs.org/@types/scheduler/-/scheduler-0.16.8.tgz", - "integrity": "sha512-WZLiwShhwLRmeV6zH+GkbOFT6Z6VklCItrDioxUnv+u4Ll+8vKeFySoFyK/0ctcRpOmwAicELfmys1sDc/Rw+A==", - "devOptional": true - }, "node_modules/@types/semver": { "version": "7.5.8", "resolved": "https://registry.npmjs.org/@types/semver/-/semver-7.5.8.tgz", @@ -57907,26 +57901,6 @@ "react-dom": "^18.0.0" } }, - "packages/headless-react/node_modules/@types/react": { - "version": "18.2.21", - "resolved": "https://registry.npmjs.org/@types/react/-/react-18.2.21.tgz", - "integrity": "sha512-neFKG/sBAwGxHgXiIxnbm3/AAVQ/cMRS93hvBpg8xYRbeQSPVABp9U2bRnPf0iI4+Ucdv3plSxKK+3CW2ENJxA==", - "devOptional": true, - "dependencies": { - "@types/prop-types": "*", - "@types/scheduler": "*", - "csstype": "^3.0.2" - } - }, - "packages/headless-react/node_modules/@types/react-dom": { - "version": "18.2.7", - "resolved": "https://registry.npmjs.org/@types/react-dom/-/react-dom-18.2.7.tgz", - "integrity": "sha512-GRaAEriuT4zp9N4p1i8BDBYmEyfo+xQ3yHjJU4eiK5NDa1RmUZG+unZABUTK4/Ox/M+GaHwb6Ow8rUITrtjszA==", - "devOptional": true, - "dependencies": { - "@types/react": "*" - } - }, "packages/headless-react/node_modules/@vitest/expect": { "version": "2.1.1", "resolved": "https://registry.npmjs.org/@vitest/expect/-/expect-2.1.1.tgz", @@ -65309,8 +65283,8 @@ }, "devDependencies": { "@types/node": "20.14.12", - "@types/react": "^18.2.0", - "@types/react-dom": "^18.2.0", + "@types/react": "18.3.3", + "@types/react-dom": "18.3.0", "cypress": "13.13.1", "cypress-repeat": "2.3.5", "cypress-web-vitals": "4.1.2", @@ -65330,8 +65304,8 @@ }, "devDependencies": { "@types/node": "20.14.12", - "@types/react": "^18.2.0", - "@types/react-dom": "^18.2.0", + "@types/react": "18.3.3", + "@types/react-dom": "18.3.0", "eslint": "8.57", "eslint-config-next": "14.2.5", "typescript": "5.4.5" @@ -65355,26 +65329,6 @@ "typescript": "5.4.5" } }, - "packages/samples/headless-ssr/node_modules/@types/react": { - "version": "18.2.21", - "resolved": "https://registry.npmjs.org/@types/react/-/react-18.2.21.tgz", - "integrity": "sha512-neFKG/sBAwGxHgXiIxnbm3/AAVQ/cMRS93hvBpg8xYRbeQSPVABp9U2bRnPf0iI4+Ucdv3plSxKK+3CW2ENJxA==", - "dev": true, - "dependencies": { - "@types/prop-types": "*", - "@types/scheduler": "*", - "csstype": "^3.0.2" - } - }, - "packages/samples/headless-ssr/node_modules/@types/react-dom": { - "version": "18.2.7", - "resolved": "https://registry.npmjs.org/@types/react-dom/-/react-dom-18.2.7.tgz", - "integrity": "sha512-GRaAEriuT4zp9N4p1i8BDBYmEyfo+xQ3yHjJU4eiK5NDa1RmUZG+unZABUTK4/Ox/M+GaHwb6Ow8rUITrtjszA==", - "dev": true, - "dependencies": { - "@types/react": "*" - } - }, "packages/samples/headless-ssr/node_modules/cypress-repeat": { "version": "2.3.5", "resolved": "https://registry.npmjs.org/cypress-repeat/-/cypress-repeat-2.3.5.tgz", diff --git a/packages/samples/headless-ssr-commerce/components/providers/listing-provider.tsx b/packages/samples/headless-ssr-commerce/components/providers/listing-provider.tsx index d0112efb942..74f863d6eb3 100644 --- a/packages/samples/headless-ssr-commerce/components/providers/listing-provider.tsx +++ b/packages/samples/headless-ssr-commerce/components/providers/listing-provider.tsx @@ -50,7 +50,7 @@ export default function ListingProvider({ engine={hydratedState.engine} controllers={hydratedState.controllers} > - <>{children} + {children} ); } else { @@ -58,9 +58,7 @@ export default function ListingProvider({ - {/* // TODO: Add KIT-3701: Type 'React.ReactNode' is not assignable to type 'import(".../node_modules/@types/react/index").ReactNode'. - Type 'bigint' is not assignable to type 'ReactNode'.*/} - <>{children} + {children} ); } diff --git a/packages/samples/headless-ssr-commerce/components/providers/search-provider.tsx b/packages/samples/headless-ssr-commerce/components/providers/search-provider.tsx index e9e099e2869..f7385ed0ea7 100644 --- a/packages/samples/headless-ssr-commerce/components/providers/search-provider.tsx +++ b/packages/samples/headless-ssr-commerce/components/providers/search-provider.tsx @@ -51,9 +51,7 @@ export default function SearchProvider({ engine={hydratedState.engine} controllers={hydratedState.controllers} > - {/* // TODO: KIT-3701: Type 'React.ReactNode' is not assignable to type 'import(".../node_modules/@types/react/index").ReactNode'. - Type 'bigint' is not assignable to type 'ReactNode'.*/} - <>{children} + {children} ); } else { @@ -61,9 +59,7 @@ export default function SearchProvider({ - {/* // TODO: KIT-3701: Type 'React.ReactNode' is not assignable to type 'import(".../node_modules/@types/react/index").ReactNode'. - Type 'bigint' is not assignable to type 'ReactNode'.*/} - <>{children} + {children} ); } diff --git a/packages/samples/headless-ssr-commerce/package.json b/packages/samples/headless-ssr-commerce/package.json index 1aafa3fe80b..4f388ac28d8 100644 --- a/packages/samples/headless-ssr-commerce/package.json +++ b/packages/samples/headless-ssr-commerce/package.json @@ -18,8 +18,8 @@ }, "devDependencies": { "@types/node": "20.14.12", - "@types/react": "^18.2.0", - "@types/react-dom": "^18.2.0", + "@types/react": "18.3.3", + "@types/react-dom": "18.3.0", "eslint": "8.57", "eslint-config-next": "14.2.5", "typescript": "5.4.5" diff --git a/packages/samples/headless-ssr/package.json b/packages/samples/headless-ssr/package.json index f5b7f10edca..092cddb5857 100644 --- a/packages/samples/headless-ssr/package.json +++ b/packages/samples/headless-ssr/package.json @@ -16,8 +16,8 @@ }, "devDependencies": { "@types/node": "20.14.12", - "@types/react": "^18.2.0", - "@types/react-dom": "^18.2.0", + "@types/react": "18.3.3", + "@types/react-dom": "18.3.0", "eslint": "8.57.0", "eslint-config-react-app": "7.0.1", "typescript": "5.4.5",