-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge performance improvements into upstream #26
Comments
Absolutely, we welcome all valuable contributions. Here's instructions on how you could contribute back to the library .. https://github.com/couchbase/vellum/blob/master/CONTRIBUTING.md |
@abhinavdangeti Just pinging to see if you got a chance to review! |
Hey @richardartoul, thanks for the contributions. Haven't had a chance to look into them yet. One of us here on the team will take a look as soon as we are able. |
Sounds good, thanks! |
Sorry for the spam, just wondering if you'd had a chance to take a look? The performance improvements are quite substantial and we hate to maintain our own fork |
Hello!
My team has been maintaining a forked branch of vellum with some performance pooling improvements. These changes have significantly reduced memory allocations and memory consumption of the FST building process in our timeseries database.
I know a previous teammate of mine (who is unfortunately on leave of absence) had begun contributing some code back to upstream. Are you open to me opening P.Rs to contribute the remaining performance improvements back? We'd love to not maintain our own fork, as well as contribute back to the library that saved us a ton of work :)
Thanks again for open sourcing such a great library.
The text was updated successfully, but these errors were encountered: