Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for more colors #7

Open
bhavyaagg opened this issue Apr 13, 2018 · 13 comments
Open

Add support for more colors #7

bhavyaagg opened this issue Apr 13, 2018 · 13 comments
Labels
enhancement New feature or request good first issue Good for newcomers mozsprint

Comments

@bhavyaagg
Copy link
Collaborator

New colors can be added for the user to draw with.

@bhavyaagg bhavyaagg added good first issue Good for newcomers mozsprint enhancement New feature or request labels Apr 13, 2018
@JesseKuntz
Copy link
Contributor

@bhavyaagg I was thinking a color wheel would be a good thing to add (maybe with hex functionality). Does that sound along the lines of what you were thinking?

@bhavyaagg
Copy link
Collaborator Author

@JesseKuntz Yes i think that would be great. We will think about adding the same functionality in the app as well. Whatsay @apoorvaagupta ?

@bhavyaagg
Copy link
Collaborator Author

@JesseKuntz You can start working on this.

@buddhikac96
Copy link

i think its better adding a color pallet.. Shall i take this..?

@bhavyaagg
Copy link
Collaborator Author

Hey @buddhikac96 Thank you for showing interest. Color pallet would also work just fine. Please allow a few hours to @JesseKuntz if he wants to complete this. You can start in a few hours if he does not reply.

@buddhikac96
Copy link

i'm working on adding a tool to change the thickness of pointer... but i get some issues... when i increase the thickness of pointer its getting nervous.. line is not clear.. please...could you give a small advice on it...

@bhavyaagg
Copy link
Collaborator Author

Hey @buddhikac96 . I am sorry to inform you but i think @JesseKuntz has already completed that feature. You can check his PR. I think by increasing the pointer thickness, the coordinates of the points are getting distanced from each other because of which the line would be becoming less clear.

@bhavyaagg
Copy link
Collaborator Author

Hey @buddhikac96 I think you can start with the color issue if you like.

@buddhikac96
Copy link

It's okay.. anyway thank you a lot for the help... shall i take that..?

@JesseKuntz
Copy link
Contributor

@buddhikac96 Feel free to take this issue (the color pallet), as I am still working on finishing up the line thickness.

@buddhikac96
Copy link

okay guys.... @bhavyaagg @JesseKuntz

@bhavyaagg
Copy link
Collaborator Author

@buddhikac96 Go ahead. All the best :)

@apoorvaagupta
Copy link
Member

@buddhikac96 Go ahead. You can add the color palette.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers mozsprint
Projects
None yet
Development

No branches or pull requests

4 participants