Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename CRATES parameter to PACKAGES or ONLY_PACKAGES #381

Open
jschwe opened this issue Apr 15, 2023 · 0 comments
Open

Rename CRATES parameter to PACKAGES or ONLY_PACKAGES #381

jschwe opened this issue Apr 15, 2023 · 0 comments
Labels
breaking-change Solving this issue requires breaking changes

Comments

@jschwe
Copy link
Collaborator

jschwe commented Apr 15, 2023

The allowlist in CRATES is actually compared against the package name, so the name CRATES is somewhat misleading. In practice the crate and package name are often the same, but still I believe the name should be changed.
@jschwe jschwe added the breaking-change Solving this issue requires breaking changes label Apr 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
breaking-change Solving this issue requires breaking changes
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jschwe