support coredns v1.11.4 and v1.12.0 #86
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/lgtm |
|
/assign @chrisohaver |
chrisohaver
requested changes
Nov 18, 2024
Signed-off-by: bzsuni <bingzhe.sun@daocloud.io>
bzsuni
force-pushed
the
bz/coredns/update/1.11.4
branch
from
ac42a32
to
1897e8e
Compare
|
@bzsuni, while double checking this I noticed that there are two options missing from cache that should have been added in a prior version. I opened an issue for it. Can you fix that in this PR? |
Signed-off-by: bzsuni <bingzhe.sun@daocloud.io>
I have added the two options, please review |
|
Could you please review when you have time? Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the release 1.11.4
the release 1.12.0
docker inspect docker.io/coredns/coredns:1.11.4 [ { "Id": "sha256:6316477a0b9ca6ac80c09ecbefcd660b06671f1307152b9a7ffcacb65d9b1d56", "RepoTags": [ "coredns/coredns:1.11.4" ], "RepoDigests": [ "coredns/coredns@sha256:4190b960ea90e017631e3e1a38eea28e98e057ab60d57d47b3db6e5cf77436f7" ], docker inspect coredns/coredns:1.12.0 [ { "Id": "sha256:1cf5f116067c67da67f97bff78c4bbc76913f59057c18627b96facaced73ea0b", "RepoTags": [ "coredns/coredns:1.12.0" ], "RepoDigests": [ "coredns/coredns@sha256:40384aa1f5ea6bfdc77997d243aec73da05f27aed0c5e9d65bfa98933c519d97"