Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for multiple data hash exclusions #622

Open
brogdonm opened this issue Oct 8, 2024 · 0 comments
Open

Add support for multiple data hash exclusions #622

brogdonm opened this issue Oct 8, 2024 · 0 comments

Comments

@brogdonm
Copy link
Contributor

brogdonm commented Oct 8, 2024

From our understanding, the data hashes, should allow for multiple exclusions. Searching through the "Issues", I found:

#560

Which may address this at some point, since the current hash block object types are:

pub enum HashBlockObjectType {
    Cai,
    Xmp,
    Other,
}

With that said, the current code simply clumps all HashBlockObjectType::Cai types together to have one range. This could be an issue where an asset type has the "Cai" block split in two different areas of the file (e.g., the beginning in a lookup table and the end).

In our work we have added the ability to treat each HashBlockObjectType::Cai as an exclusion range, de-fragmenting any areas that are adjacent to each other in memory.

Note: I plan to subsequently raise a PR for this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant