Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: scale_x_upset order_by weighted frequency #21

Open
mdhall272 opened this issue Feb 8, 2021 · 1 comment
Open

Feature request: scale_x_upset order_by weighted frequency #21

mdhall272 opened this issue Feb 8, 2021 · 1 comment

Comments

@mdhall272
Copy link

mdhall272 commented Feb 8, 2021

I've been using ggupset for datasets where each datapoint has a weight, but when you set the weight aesthetic in geom_bar, the order generated by scale_x_upset(order_by = "freq") is still the order of the unweighted data. It would be nice to have the option of sorting by weighted total.

Thanks for the great package!

@const-ae
Copy link
Owner

const-ae commented Feb 8, 2021

That's interesting, I didn't even know that geom_bar() had a weightaesthetics. However, I currently don't have the bandwith to implement this myself. But I am happy to accept a PR.

You would probably have to start here and see if there is an easy way to check if the weight aesthetics has been set.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants