Skip to content
This repository has been archived by the owner on Jan 24, 2021. It is now read-only.

Fix spacing issues #72

Open
Torgian opened this issue Feb 21, 2020 · 4 comments
Open

Fix spacing issues #72

Torgian opened this issue Feb 21, 2020 · 4 comments
Assignees

Comments

@Torgian
Copy link
Contributor

Torgian commented Feb 21, 2020

Update: Refer to PR #73
Upon reviewing the page as it stands, there are still a few spacing issues in a few spots.

Too much space below "How does it work" and the icons.
Screen Shot 2020-02-21 at 10 13 00 AM

A bit too much pace below " Our solution " and the paragraph text. In mobile view, it looks fine.

Screen Shot 2020-02-21 at 10 16 57 AM

"The technology" has a lot of space between the title and the paragraph. This was done originally to keep everything more in-line with the code block on the right on desktop view. In the Zeplin file
This calls for more space between the first and second paragraphs. @marcchataigner @Tannybunny can you review?

Original:
Screen Shot 2020-02-21 at 10 18 40 AM

Potential change:

Screen Shot 2020-02-21 at 10 22 58 AM

Next, a little too much margin below "Co-ownership" and paragraph below; same with Data integrity and Consento roadmap
Screen Shot 2020-02-21 at 10 25 04 AM
:
Screen Shot 2020-02-21 at 10 24 23 AM

Screen Shot 2020-02-21 at 10 25 52 AM

@Tannybunny
Copy link
Contributor

Tannybunny commented Feb 27, 2020

I agree these spacings need to be fixed.
I made an example for the "our solution" section, which first of all should not be aligned to the right, this never looks good.

If possible, I would align them to the left and center the whole text block with the image.
The space between "h2 "and "p" is 30 pixel and the space between "p" and the button is 60 pixel.
Also I think it might be good to change the link of the button to for example https://play.google.com/store/apps/details?id=org.consento.mobile and label it as a download button? If we want people to sign up for the newsletter maybe we should have a separate newsletter section?

Could you try to apply this? We can use the same spacing for the other spaces between a "h2" and "p" I guess

Screen Shot 2020-02-27 at 12 18 44

Torgian added a commit that referenced this issue Mar 3, 2020
Torgian added a commit that referenced this issue Mar 3, 2020
…rride line 72 of typography.scss. Refer to #71 and adds to #72
@Torgian
Copy link
Contributor Author

Torgian commented Mar 3, 2020

Refer to 2d60b9d for another fix

Torgian added a commit that referenced this issue Mar 3, 2020
…cally these are titles in blog posts and pages. Refer to #72. This was a requested change.
Torgian added a commit that referenced this issue Mar 3, 2020
…remove bottom margin from header titles. Adds to #72.
@Tannybunny
Copy link
Contributor

Is it possible to center the "our solution" text with the image of the phone ?

@Tannybunny
Copy link
Contributor

Also, I think due to recent changes the positioning of the "Co-ownership of confidential data." illustration (mountain in the background) changed a bit, it's now a bit too close the previous content. If possible, move it a bit more downwards, best would be to center it with the text

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants