Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shimmy #8

Open
thewchan opened this issue Dec 14, 2022 · 11 comments
Open

Shimmy #8

thewchan opened this issue Dec 14, 2022 · 11 comments
Labels
question Further information is requested

Comments

@thewchan
Copy link
Contributor

Comment:

@h-vetinari Part of the challenge is also this: https://github.com/conda-forge/shimmy-feedstock/, which I have recently brought to conda forge in anticipation of Gymnasium 0.27. The thing is that there are many optional dependency there too, and I suppose we should support all those, but several of them are not on Conda yet. Including:

https://pypi.org/project/dm-control/
https://pypi.org/project/open-spiel/
https://pypi.org/project/PettingZoo/

At least, in my first search over in Conda Forge, I don't think those are in the catalogue yet. Thoughts?

@thewchan thewchan added the question Further information is requested label Dec 14, 2022
@thewchan
Copy link
Contributor Author

CC: @jkterry1
@pseudo-rnd-thoughts

@h-vetinari
Copy link
Member

I'd like to first get the transition release of gym->gymnasium into conda-forge, i.e. 0.26.1 with all relevant extras. Then we can tackle shimmy and that ecosystem...

@thewchan
Copy link
Contributor Author

@h-vetinari good call, you mentioned gym last version and gymnasium 0.26.1 is essentially identical? Would the recipe require little changes then between the 2?

@h-vetinari
Copy link
Member

Would the recipe require little changes then between the 2?

That's the idea, yes. Which is why I want to "import" the history of the gym feedstock to have a more or less seamless transition from gym to gymnasium (and we can keep the old gym-outputs as wrappers for the gymnasium packages for a while, so people wanting to upgrade gym would get gymnasium automatically).

See discussions in conda-forge/gym-feedstock#29 and conda-forge/staged-recipes#21485

@thewchan
Copy link
Contributor Author

@h-vetinari since you have access now (let me know of others to add) do you want to take the lead? Happy to help otherwise

@h-vetinari
Copy link
Member

@h-vetinari since you have access now (let me know of others to add) do you want to take the lead? Happy to help otherwise

Yes, I just need to get to a computer and have a moment. Give me a few hours.

@traversaro
Copy link
Contributor

@pseudo-rnd-thoughts
Copy link
Contributor

I must have missed this thread.
Are we able to just have the base install with non of the optional installs.
Then we can iteratively add support for each of the modules

@pseudo-rnd-thoughts
Copy link
Contributor

Shimmy is being removed as a non-necessary module in v0.27.1 but it would be nice to add support in the future.

@h-vetinari
Copy link
Member

I opened an issue (plus a couple follow-ups) for the remaining shimmy optional dependencies: conda-forge/shimmy-feedstock#7

@ChristofKaufmann, any chance of interesting you to help out with that? ;-)

@ChristofKaufmann
Copy link
Contributor

@h-vetinari Maybe I could do PettingZoo... but I will be gone camping without laptop very soon. So, I am not sure yet, when I can do it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

5 participants