Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix context menu from going off-screen #6148

Draft
wants to merge 7 commits into
base: master
Choose a base branch
from
Draft

Conversation

lankaukk
Copy link
Collaborator

@lankaukk lankaukk commented Jul 30, 2024

Problem:
The context menu for canvas elements was going off screen.

Fix:
Now the context menu content scrolls vertically, and has a maximum height responsive to the visible screen height.

Before After
Content Cell Content Cell
Content Cell Content Cell

Manual Tests:
I hereby swear that:

  • I opened a hydrogen project and it loaded
  • I could navigate to various routes in Preview mode

Copy link
Contributor

github-actions bot commented Jul 30, 2024

Try me

Copy link

relativeci bot commented Jul 30, 2024

#13600 Bundle Size — 62.65MiB (~+0.01%).

3c02312(current) vs 6339ece master#13586(baseline)

Warning

Bundle contains 70 duplicate packages – View duplicate packages

Bundle metrics  Change 2 changes Regression 1 regression
                 Current
#13600
     Baseline
#13586
Regression  Initial JS 45.73MiB(~+0.01%) 45.73MiB
No change  Initial CSS 0B 0B
Change  Cache Invalidation 22.23% 21.56%
No change  Chunks 31 31
No change  Assets 34 34
No change  Modules 4377 4377
No change  Duplicate Modules 525 525
No change  Duplicate Code 31.64% 31.64%
No change  Packages 469 469
No change  Duplicate Packages 70 70
Bundle size by type  Change 2 changes Regression 1 regression Improvement 1 improvement
                 Current
#13600
     Baseline
#13586
Regression  JS 62.64MiB (~+0.01%) 62.64MiB
Improvement  HTML 11.16KiB (-0.33%) 11.2KiB

Bundle analysis reportBranch fix-context-menuProject dashboard

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants