Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#182 Valid check_min_cppstd #184

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

uilianries
Copy link
Member

closes #182

#KB-H046: "VALIDATE CHECK_MIN_CPPSTD"

The method tools.check_min_cppstd uses the default c++ standard supported by the compiler, when settings.compiler.cppstd is not defined. However, is can cause false-positives when a compiler supports a determined c++ standard.

Signed-off-by: Uilian Ries <uilianries@gmail.com>
Signed-off-by: Uilian Ries <uilianries@gmail.com>
@uilianries uilianries marked this pull request as ready for review April 24, 2020 18:15
@uilianries uilianries requested review from danimtb and SSE4 April 24, 2020 18:15
Copy link
Contributor

@jgsogo jgsogo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably this hook is too fragile. IMO the cppstd issue is something to fix in the CI itself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[conan-center-index] Checks for semantic errors
3 participants