Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

javascript not supported? #197

Open
haraldschilly opened this issue Mar 30, 2023 · 2 comments
Open

javascript not supported? #197

haraldschilly opened this issue Mar 30, 2023 · 2 comments

Comments

@haraldschilly
Copy link

when I try testing a javascript notebook, all cells fail with

ERROR nbval-tests/22.04/javascript.ipynb::Cell 0 - KeyError: 'status'

that's how a cell looks like in the notebook – in case that helps

  {
   "cell_type": "code",
   "execution_count": 1,
   "metadata": {
    "collapsed": false
   },
   "outputs": [
    {
     "data": {
      "text/plain": [
       "'v16.16.0'"
      ]
     },
     "execution_count": 1,
     "metadata": {
     },
     "output_type": "execute_result"
    }
   ],
   "source": [
    "process.version"
   ]
  },
@takluyver
Copy link
Member

Probably coming from this line:

if msg['content']['status'] == 'aborted':

I would guess that can be relaxed with a .get() - do you want to make PR?

@haraldschilly
Copy link
Author

Yes, that looks like where this is coming from. No to the PR, sorry 🏃 🙈

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants