Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add eventstore team as codeowners #480

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

JPisCoding
Copy link
Contributor

@JPisCoding JPisCoding commented Feb 20, 2023

Since these libraries are quite relevant to our persistence layer, this change adds team "eventstore" as code-owners, since this is part of their core domain.

@JPisCoding
Copy link
Contributor Author

⚠️ I also took the liberty of also giving the team write access, since github complained about the file being invalid without it.

@JPisCoding JPisCoding marked this pull request as ready for review February 20, 2023 12:17
Copy link
Contributor

@yanns yanns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we disclose our internal team structure on open source projects?

@JPisCoding
Copy link
Contributor Author

Should we disclose our internal team structure on open source projects?

That's a valid question. Frankly, I didn't even think of this. In the spirit of the question, maybe we should not discuss the concern here, then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants