Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider supporting the new & native java.net.http API as a client #1821

Open
nkuehn opened this issue Sep 25, 2018 · 2 comments
Open

Consider supporting the new & native java.net.http API as a client #1821

nkuehn opened this issue Sep 25, 2018 · 2 comments

Comments

@nkuehn
Copy link

nkuehn commented Sep 25, 2018

Version conflics on apache async HTTP and / or the netty based client are an ongoing chore in projects using the JVM SDK - that's not a commercetools specific problem but a pretty generic one.

I just read that Java 11 has now promoted the JVM-builtin java.net.http API to stable. It's fully asynchronous so it could be okay as an addition (or even default on Java 11+ if no other client is configured).

I haven't fully analyzed or ever used it, that's why this is a "consider" issue only

@acbeni acbeni added this to the v2.0.0 milestone Sep 26, 2018
@acbeni
Copy link
Contributor

acbeni commented Sep 26, 2018

Yeah actually i took a look at that and i like that this client comes with java standard packages, but we don't have a plan to migrate to java 11 for the moment especially that this change itself would be breaking for us (since we have to change some packages names + dependencies to have the module structure).
So i will leave this issue open, and i ll include it with the blocking label so we might introduce it once we intend to pass to sdk 2.0

@butenkor
Copy link
Member

@acbeni I wonder why do you think that we need to do breaking changes? Modularization is optional as far as i know. SDK wrapper of native HTTP client could be supplied as own dependency so new release could work with both Java 8 and Java 11 (if native client has to be used).

@ashishhk ashishhk removed this from the v2.0.0 milestone May 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants