Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP/QRCoder2] System.Drawing vs X #548

Open
Tracked by #512
codebude opened this issue May 26, 2024 · 2 comments
Open
Tracked by #512

[WIP/QRCoder2] System.Drawing vs X #548

codebude opened this issue May 26, 2024 · 2 comments
Labels
qrcoder2 Everything related to QRCoder v2

Comments

@codebude
Copy link
Owner

Note: This issue is part of the planning of version 2 of the QRCoder. The meta-issue can be found here. These comments have been copied into this issue here, with the comments marked as such. If comments on the topic of this issue already exist in the meta thread, they have been copied here, naming the authors.

Topic - Part A

Should we keep System.Drawing.Common based renderers and add new ones with library 'X' or do we ditch System.Drawing.Common completely and replace it with library 'X'?

Topic - Part B

In past discussions, several libraries have been mentioned as replacements for System.Drawing. Among others ImageSharp (now partly has to be licensed?), SkiaSharp (native dependencies under Linux), Maui.Graphics or something else?

@codebude codebude added the qrcoder2 Everything related to QRCoder v2 label May 26, 2024
@codebude
Copy link
Owner Author

Part A

I suggest maintaining the existing code. While it's usefulness is likely declining, I see no reason to pitch the existing code. It will certainly be useful for existing users that wish to upgrade to 2.x, and serves as a template (if we like the design pattern) for SkiaSharp / ImageSharp / etc.

Originally posted by @Shane32 here.

Part B

I suggest 'whatever contributors wish to offer PRs for'. Ideally:

  • System.Drawing.Common
  • SkiaSharp
  • ImageSharp 2.x
  • ImageSharp (latest)
  • Maui.Graphics

Compare to ZXing.Net which has these NuGet packages available:

  • ZXing.Net.Bindings.Windows.Compatibility
  • ZXing.Net.Bindings.SkiaSharp
  • ZXing.Net.Bindings.ImageSharp
  • ZXing.Net.Bindings.ImageSharp.V2

Originally posted by @Shane32 here.

@codebude
Copy link
Owner Author

ImageSharp is your friend.

Originally posted by @catdsnny here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
qrcoder2 Everything related to QRCoder v2
Projects
None yet
Development

No branches or pull requests

1 participant