Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

the minified version will create a global variable d #21

Open
lpetrov opened this issue Sep 17, 2014 · 1 comment
Open

the minified version will create a global variable d #21

lpetrov opened this issue Sep 17, 2014 · 1 comment

Comments

@lpetrov
Copy link

lpetrov commented Sep 17, 2014

In most cases this should not be a problem, but creating global variables is not a good idea.

The minified version should be scoped by a (function(){ ... })() and only expose the expected/required/public functions/variables, e.g. $.fullScreen.

@humancalendar
Copy link

Yeah, it looks like the supplied minified version (jquery.fullscreen-min.js) has not been updated since its code doesn't match that of the non-minified version. The non-minified version has the correct scoping as you indicate, but the supplied minified version does not.

I manually minified the jquery.fullscreen.js file and ended up with the proper scoping and a minified file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants