Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

storage: Remove gaps in dialogs #18951

Closed

Conversation

mvollmer
Copy link
Member

@mvollmer mvollmer commented Jun 15, 2023

Before:

image

After:

image

Copy link
Member

@garrett garrett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With the space, it looks a little odd, but without the space (or some separation or some kind of grouping or distinction) in this specific modal, it's very confusing. This is due to using the repeat passphrase pattern (which I don't agree with, but that's a different discussion) and the unlock passphrase (which is different, but all three passphrases here gets really weird, really fast).

This specific modal probably could have improvements (reveal passphrase, passphrase strength) and perhaps even a redesign.

However, @jelly pointed out this change is probably related to a different modal, where the space is definitely a problem:

image

@mvollmer
Copy link
Member Author

However, @jelly pointed out this change is probably related to a different modal, where the space is definitely a problem:

image

That dialog was part of #18818 and the gap was fixed before it was merged:

image

So I guess we can close this here.

@mvollmer mvollmer closed this Aug 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants