Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IMDSv2 support #10

Open
1 of 3 tasks
condour opened this issue Jun 14, 2022 · 7 comments
Open
1 of 3 tasks

IMDSv2 support #10

condour opened this issue Jun 14, 2022 · 7 comments

Comments

@condour
Copy link

condour commented Jun 14, 2022

Please specify whether your issue is about:

  • a possible bug
  • a question about package functionality
  • a suggested code or documentation change, improvement to the code, or feature request

IMDS v2 requires that a token be requested prior to getting metadata. This should be a fairly simple fix - issue the token request prior to curling for the metadata. Thoughts?

@condour
Copy link
Author

condour commented Jul 15, 2022

I've put in a PR for a fix.

@gs-scooter
Copy link

Can someone please review and merge this PR? This is a blocker for us.

@jb2cool
Copy link

jb2cool commented Dec 8, 2022

We've stumbled across this too, this is impacting things for us where we are trying to follow best practice.

@condour
Copy link
Author

condour commented Apr 23, 2023

Just a note that I've updated the branch to address PR comment.

@EwanStephens
Copy link

@condour @laurenkahn I see an approved PR for IMDSv2 support. Would it be possible to merge the PR? We also require IMDSv2 only on our EC2 instances and can't use this package without it. Thanks for your help!

@laurenkahn
Copy link

I don't have write access to merge. @leeper might need to merge?

@tyner
Copy link

tyner commented Feb 20, 2024

Would be great to see this merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants