Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to set an IP sets description #93

Closed
l3rady opened this issue Aug 9, 2024 · 1 comment
Closed

Add ability to set an IP sets description #93

l3rady opened this issue Aug 9, 2024 · 1 comment

Comments

@l3rady
Copy link

l3rady commented Aug 9, 2024

Describe the Feature

For the IP Set rules to work this module converts the rules to IP sets but sets the description as blank with no way to configure it.

It does look like the developer did intend at some point to pull the description from the rule but looks for the setting description which isn't set as part of the rule: https://github.com/cloudposse/terraform-aws-waf/blob/main/ipset.tf#L28

Please add the ability to add a description to ipset rules.

Expected Behavior

IP set description set based on config of ip set statement rules. If none set the default "Managed by Terraform" set

Use Case

N/A

Describe Ideal Solution

Add optional description variable to ip_set_reference_statement_rules list

Alternatives Considered

No response

Additional Context

No response

@l3rady
Copy link
Author

l3rady commented Aug 9, 2024

Closing feature as PEBCAK.

can put description in the statement block.

@l3rady l3rady closed this as completed Aug 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant