Skip to content
This repository has been archived by the owner on Feb 10, 2022. It is now read-only.

Enable flagging a kubelet as a master node for tainting. #333

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

svrc
Copy link
Collaborator

@svrc svrc commented Jun 21, 2019

What this PR does / why we need it:
This enables labeling and tainting on master nodes that wish to deploy a Kubelet. This is the foundation to enable pluggable CNI support in CFCR.

How can this PR be verified?
Deploy CFCR with a kubelet on the master node. The node should be labeled node-role.kubernetes.io/master= and tainted node-role.kubernetes.io/master=:NoSchedule

Is there any change in kubo-deployment?
Yes (forthcoming), an ops file that will deploy CFCR with kubelets on the master.

Is there any change in kubo-ci?
Yes (forthcoming), to test this variant of CFCR deployment.

Does this affect upgrade, or is there any migration required?
No, though future capabilities that build on this may (e.g. pluggable CNIs).

Which issue(s) this PR fixes:
N/A

Release note:

@cfdreddbot
Copy link

✅ Hey svrc-pivotal! The commit authors and yourself have already signed the CLA.

Copy link
Member

@tvs tvs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR shouldn't be necessary - everything that's happening here can already be done as part of the existing k8s-args properties.

Taints can be registered using --register-with-taints and the labels can be added to --node-labels.

@svrc
Copy link
Collaborator Author

svrc commented Jun 25, 2019 via email

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Nov 14, 2019

CLA Check
One or more committers are not authorized under a signed CLA as indicated below. Please click here to be authorized. For further assistance with EasyCLA, please submit a support request ticket.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants