Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DISCUSSION: Sub-commands as libraries with entry points #190

Open
jwerle opened this issue Jul 23, 2020 · 5 comments
Open

DISCUSSION: Sub-commands as libraries with entry points #190

jwerle opened this issue Jul 23, 2020 · 5 comments

Comments

@jwerle
Copy link
Member

jwerle commented Jul 23, 2020

See #116

@Isty001
Copy link
Member

Isty001 commented Jan 15, 2021

I was thinking about this issue, and my opinion is that we should compile a single binary.

Pros:

  • Lot of code duplication could be removed
  • Much more maintainable
  • Building clib is simpler
  • Solves the mentioned issue

Cons:

  • Breaking change
  • clib-* binaries won't be picked up as subcommands. However this could gradually removed, and replaced with a different plugin solution.

Any ideas on this?

@jwerle
Copy link
Member Author

jwerle commented Jan 15, 2021

I like the idea and could be an opportunity to really have a clean linkable C library for embedding clib or other programmatic usage. +1 for plugins

@stephenmathieson
Copy link
Member

While it is a breaking change, I don't imagine many folks are leveraging the subcommand/plugin feature. There are only two plugins (listed in our registry) and I wrote both 🤣 I don't think our users would be too upset about us dropping support here.

My only concern: what would we do with the existing "plugins"? Do we just archive them? Do they provide enough value to get merged into "core"?

@Isty001
Copy link
Member

Isty001 commented Jan 16, 2021

I think it's worth to move them to clib, and have them by default. I actually opened an issue for this #239 and I'll take a look at it soon.

@stephenmathieson
Copy link
Member

Wrong button 🤦‍♂️

I didn't see that issue until now. Moving them into core SGTM 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: To do
Development

No branches or pull requests

3 participants