Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Random Merchant Republics #286

Open
CJ3625 opened this issue Aug 11, 2024 · 3 comments
Open

Random Merchant Republics #286

CJ3625 opened this issue Aug 11, 2024 · 3 comments
Labels
bug Needs Research

Comments

@CJ3625
Copy link

CJ3625 commented Aug 11, 2024

Playing with last branch, k_africa in the 769 start starts as a merchant republic, also seeing many other random republics that are not present in the 5.0 beta 5.1 release, i think the issue is in the government potential triggers, would appreciate any response, thanks.
@schwarherz
Copy link
Contributor

Looked into it and can confirm that there seem to be several merchant republics where there shouldn't be, most noticeably k_africa in 769. I suspect it's an error in the history files since the issue persists even after I re-aligned the government files with CleanSlate normals but this will need more research.

@schwarherz
Copy link
Contributor

Nope it's definitely a government thing. No idea what's specifically doing it though. I have it fixed for now in dev but I suspect the fix is a band-aid for a bigger issue.

schwarherz added a commit that referenced this issue Sep 12, 2024
@schwarherz
Anti-random-republic safety check
64b0495 
For #286

This seems to fix the issue. I'm unsure if it's a true fix or just surface-level cover. Needs looked into further.
schwarherz added a commit that referenced this issue Sep 16, 2024
@schwarherz
Update Plus Governments to CleanSlate standards
1c5e1c8 
Previous fix was not an actual fix. Problem appears to be in the history. #286 still ongoing.
@schwarherz schwarherz pinned this issue Sep 16, 2024
@schwarherz
Copy link
Contributor

Was unable to identify the specific problem other than that it was in province history. Will be fixed in the coming cleanslate recompatch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Needs Research
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@schwarherz @CJ3625