Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: Fix flaky MediaAccessTest.* #3831

Open
magreenblatt opened this issue Nov 13, 2024 · 0 comments
Open

tests: Fix flaky MediaAccessTest.* #3831

magreenblatt opened this issue Nov 13, 2024 · 0 comments
Labels
bug Bug report Tests Related to tests

Comments

@magreenblatt
Copy link
Collaborator

To Reproduce
Steps to reproduce the behavior:

  1. Run cefclient --gtest_filter=MediaAccessTest.* --use-views

Expected behavior
Tests should succeed. Instead, some tests fail.

On Windows:

[  FAILED  ] MediaAccessTest.DeviceSuccessAudioVideo
[  FAILED  ] MediaAccessTest.DeviceSuccessAudioVideoAsync
[  FAILED  ] MediaAccessTest.DesktopPartialSuccessReturningVideo

On MacOS:

[  FAILED  ] MediaAccessTest.DeviceSuccessAudioOnly
[  FAILED  ] MediaAccessTest.DeviceSuccessVideoOnly
[  FAILED  ] MediaAccessTest.DeviceSuccessAudioVideo
[  FAILED  ] MediaAccessTest.DeviceSuccessAudioVideoAsync
[  FAILED  ] MediaAccessTest.DesktopPartialSuccessReturningVideo

Sample failure:

[ RUN      ] MediaAccessTest.DeviceSuccessAudioOnly
../../cef/tests/ceftests/media_access_unittest.cc:255: Failure
Expected equality of these values:
  got_audio_device() || got_audio_desktop()
    Which is: true
  has_audio_access
    Which is: false
../../cef/tests/ceftests/media_access_unittest.cc:256: Failure
Value of: test_setup_->got_change
  Actual: true
Expected: false

Versions (please complete the following information):

  • OS: Windows 11, MacOS 15.0.1
  • CEF Version: M131
@magreenblatt magreenblatt added bug Bug report Tests Related to tests labels Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Bug report Tests Related to tests
Projects
None yet
Development

No branches or pull requests

1 participant