-
Notifications
You must be signed in to change notification settings - Fork 129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Project refactored PSR1/2/4, OOP, PHP 5.6+ complement framework yii2 #37
Comments
https://github.com/spiritdead/resque/blob/master/composer.json#L13-L18 You've wiped the history of the repo and removed the original author from composer.json. If this is a refactoring, why did you deliberately claim everything to yourself? If this is a complete rewrite, why is there code from this repo in your repo without credit? It's good that someone is working on the code, but I don't think that this is the way to go. |
@firoxer this is a refactor, this no have any documentation, readme, nothing, i need to add all of these things, if you can provide me i can add in the next commit, i put that for my package |
You didn't really answer the question... |
@firoxer i forgot, i'm telling you, i'm not in my house to refresh the composer, and i have to push some changes too |
@firoxer for the version 1.0.4 i added a special thanks |
In my opinion "inspired by X" is insufficient when most of the code is not yours but copied and pasted. |
you can see the repo, the code is completly different, but i have to improve the Polymorphism and base classes |
You seem to be unable to see the problem. This conversation is pointless. |
tonight i will push a couple of improvements, but this is my refactor, i rewrite this completely from the beginning and i fix a couple of bugs from the old version
https://github.com/spiritdead/resque + plugin php-resque-scheduler
https://github.com/spiritdead/yii2-resque
if someone want to help me improving this welcome
The text was updated successfully, but these errors were encountered: