Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove copy and switch to return SamplerState #24

Open
wiederm opened this issue Jan 23, 2024 · 0 comments · Fixed by #21
Open

Remove copy and switch to return SamplerState #24

wiederm opened this issue Jan 23, 2024 · 0 comments · Fixed by #21

Comments

@wiederm
Copy link
Member

wiederm commented Jan 23, 2024

In multiple places throughout the code, we are making deepcopies of the SamplerState. This is not necessary. Related to that, we should avoid modifying the SamplerState in place and return the SamplerState.
@chrisiacovella chrisiacovella mentioned this issue Jan 23, 2024
Closed
@wiederm wiederm mentioned this issue Feb 8, 2024
Merged
1 task
@wiederm wiederm linked a pull request Feb 9, 2024 that will close this issue
Refactoring of MC moves #21
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Refactoring of MC moves choderalab/chiron
1 participant
@wiederm