Skip to content

Latest commit

 

History

History
208 lines (153 loc) · 11 KB

COMMITTERS.md

File metadata and controls

208 lines (153 loc) · 11 KB
Raw

Committers

Branching Strategy

This repository uses the following branching strategy:

Branching Strategy

Depending on where your fix/enhancement goes, please target the proper branch. Community members always target develop, but committers should know where the fix they are presenting goes. It makes it much easier to push the shiny green button on a pull request. If you are not sure where to target, ask.

Features

Creating a feature branch

git checkout -b myfeature develop

Finishing a feature branch

git checkout develop
git merge --no-ff myfeature
git branch -d myfeature
git push origin --delete myfeature # if feature branch pushed to fork repository
git push upstream develop
git push origin develop

Releases

Creating a release branch

git checkout -b release/0.2.0 develop

Finishing a release branch

git checkout master
git merge --no-ff release/0.2.0
git tag -a 0.2.0 -m "version 0.2.0"
git checkout develop
git merge master
git branch -d release/0.2.0
git push upstream --delete release/0.2.0 # if release branch pushed to main repository
git push upstream master
git push upstream develop
git push origin master
git push origin develop

Hotfixes

Creating a hotfix branch

git checkout -b hotfix/0.1.1 master

Finishing a hotfix branch

git checkout master
git merge --no-ff hotfix/0.1.1
git tag -a 0.1.1 -m "version 0.1.1"
git checkout develop
git merge master
git branch -d hotfix/0.1.1
git push upstream --delete hotfix/0.1.1 # if hotfix branch pushed to main repository
git push upstream master
git push upstream develop
git push origin master
git push origin develop

Summary

We like to see folks contributing to Chocolatey. If you are a committer, we'd like to see you help from time to time with triage and the pull request process.

In all cases politeness goes a long way. Please thank folks for contributions - they are going out of their way to help make the code base better, or adding something they may personally feel is necessary for the code base.

Please be VERY familiar with CONTRIBUTING and follow the process as well.

Terminology

Contributor - A person who makes a change to the code base and submits a change set in the form of a pull request.

Change Set - A set of discrete commits which combined together form a contribution. A change set takes the form of git commits and is submitted in the form of a pull request. Used interchangeably with "pull request".

Committer - A person responsible for reviewing a pull request and then making the decision what base branch to merge the change set into.

Review Process

Receive new PR (pull request)

  • A contributor sends a pull request (usually against develop).
  • A committer typically reviews it within a week or less to determine the feasibility of the changes.

Initial PR Review

  • Has the user signed the Contributor License Agreement (CLA)?
  • Did the user create a branch with these changes? If it is on their default branch (i.e. develop), please ask them to review CONTRIBUTING.
  • Did the user reformat files and they should not have? Was is just white-space? You can try adding ?w=1 to the URL on GitHub.
  • Are there tests? We really want any new contributions to contain tests so unless the committer believes this code really needs to be in the code base and is willing to write the tests, then we need to ask the contributor to make a good faith effort in adding test cases. Ask them to review the contributing document and provide tests. Note: Some commits may be refactoring which wouldn't necessarily add additional test sets.
  • Is the code documented properly? Does this additional set of changes require changes to the documentation?
  • Was this code warranted? Did the contributor follow the process of gaining approval for big change sets? If not please have them review the contributing document and ask that they follow up with a case for putting the code into the code base on the mailing list.

Review the Code

  • Does the code meet the naming conventions and formatting (need link)?
  • Is the code sound? Does it read well? Can you understand what it is doing without having to execute it? Principal of no clever hacks (need link).
  • Does the code do what the purpose of the pull request is for (and only that)?

Accepting a PR

Once you have reviewed the initial items, and are not waiting for additional feedback or work by the contributor, give the thumbs up that it is ready for the next part of the process (merging).

Unless there is something wrong with the code, we don't ask contributors to rebase against develop. They did the work to create the patch in the first place, asking them to unnecessarily come back and try to keep their code synced up with develop is not an acceptable process.

Merging

Once you have reviewed the change set and determined it is ready for merge, the next steps are to bring it local and evaluate the code further by actually working with it, running the tests locally and adding any additional commits or fix-ups that are necessary in a local branch.

When merging the user's contribution, it should be done with git merge --log --no-ff to create a merge commit so that in case there is an issue it becomes easier to revert later, and so that we can see where the code came from should we ever need to go find it later (more information on this can be found here and also a discussion on why this is a good idea here).

Pull Request Retargeting

Because we ask contributors to target develop, sometimes a fix/enhancement may need to be retargeted to a hotfix, or release, branch. This process is somewhat easy thanks to git. In most cases you won't even need to ask the user to do this for you.

  • git fetch upstream pull/<github_pull_id>/head:pr<github_pull_id> - upstream is git@github.com:chocolatey/choco.git
  • git checkout pr<github_pull_id>
  • git rebase --onto hotfix/0.2.2 develop - this uses the local branch, starts with latest hotfix/0.2.2 and reapplies the commits from the branch to it, removing all commits that were only on the develop. NOTE: This is just an example, you should use the name of the hotfix/release branch that is currently being used.
  • build.bat - build and test
  • Any additional changes or testing here.
  • git checkout hotfix/0.2.2
  • git fetch upstream - if this pulls anything, make sure to also run git rebase upstream/hotfix/0.22 prior to merging or you will lose the merge commit.
  • git merge pr<github_pull_id> --log --no-ff
  • git branch -d pr<github_pull_id>
  • Make any last checks to ensure the git logs look good. The next step sets the commits in stone and unable to be changed.
  • git push upstream

References

Generating and Updating Cmdlet Documentation

Documentation for the cmdlets in the Chocolatey.PowerShell project is maintained as *.md files in the chocolatey/docs repository, under input/en-us/create/cmdlets. When making changes to a cmdlet or adding a new one, we need to ensure that those Markdown files get updated, and that those changes are propagated back to this repository in the Chocolatey.PowerShell.dll-help.xml file in the repository.

Before working with this, be sure to clone the chocolatey/docs repository locally. If your local copy of the docs repository is not located at ../docs relative to this folder, you will need to specify the -DocsRepositoryPath parameter whenever calling the update-cmdlet-documentation.ps1 script.

Generating Documentation for a new Cmdlet

Run the update-cmdlet-documentation.ps1 script with the -NewCommand parameter, specifying the name of the cmdlet(s) that you've added:

./update-cmdlet-documentation.ps1 -NewCommand Test-NewChocolateyCommand

Once this completes, you will get a warning that the documentation template needs to be filled out and the newly-generated documentation file will open in your default editor for *.md files.

Updating Documentation For an Existing Cmdlet

Run the update-cmdlet-documentation.ps1 script:

./update-cmdlet-documentation.ps1

Generating the Chocolatey.PowerShell.dll-help.xml External Help Documentation

Once new files have been generated, in the chocolatey/docs repository, make any additional changes needed to the files. Note that these files will need to be compatible both with PlatyPS and the docs repository Markdown formatting. As such, for new files you will need to sure the additional frontmatter is added. A complete frontmatter block for these files looks like this:

---
Description: Information on Cmdlet-Name cmdlet
external help file: Chocolatey.PowerShell.dll-Help.xml
Module Name: Chocolatey.PowerShell
online version: https://docs.chocolatey.org/en-us/create/functions/cmdlet-name
Order: 70
schema: 2.0.0
Title: Cmdlet-Name
xref: cmdlet-name
---

Some files may also have a RedirectFrom: [ ... ] frontmatter entry. This is not required for new files, but existing files (or files added for a cmdlet that is a rewrite of a pre-existing command) should retain their existing redirects.

Run the update-cmdlet-documentation.ps1 script once more, and add the changes to the Chocolatey.PowerShell.dll-help.xml file to a commit.

Finally, add the changes to a commit on a new branch in the docs repository and submit a PR for any changes there as well, alongside the PR to any changes made in this repository. If you are rewriting a cmdlet from a pre-existing script command, ensure you remove the old documentation file from input/en-us/create/commands as well, so that there are no duplicate xrefs.