-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace Turbolinks with Turbo (and upgrade Stimulus) #1181
Merged
Merged
Commits on Nov 17, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 6c12a3b - Browse repository at this point
Copy the full SHA 6c12a3bView commit details -
Configuration menu - View commit details
-
Copy full SHA for f2de076 - Browse repository at this point
Copy the full SHA f2de076View commit details -
Configuration menu - View commit details
-
Copy full SHA for a52946a - Browse repository at this point
Copy the full SHA a52946aView commit details -
Update render and redirect calls as required by Turbo.
Turbo requires that redirects returned by form submissions have a status of 303 (see other) so that the browser will follow them with a GET request and not use the HTTP method of the submission request. This is semantically correct, but a change in behavior from how Rails UJS handled things. Additionally, Turbo will not render anything when a 200 response is returned by a form submission, instead requiring that a 422 (unprocessable entity) status is returned in order for it to render the new HTML and its validation error messages. This is going to become the Rails default in the future.
Configuration menu - View commit details
-
Copy full SHA for 8e18eda - Browse repository at this point
Copy the full SHA 8e18edaView commit details -
Configuration menu - View commit details
-
Copy full SHA for f229556 - Browse repository at this point
Copy the full SHA f229556View commit details -
Rebuild note CRUD using turbo frames.
There was previously a single controller and set of views that handled all note CRUD for both Member and Item. As a part of reworking this code, I created separate controllers and views for the notes on each of these models. I think this will be eaiser to understand and will allow the notes placed on each model to diverge more easily.
Configuration menu - View commit details
-
Copy full SHA for 3ee9c02 - Browse repository at this point
Copy the full SHA 3ee9c02View commit details
Commits on Nov 19, 2023
-
Configuration menu - View commit details
-
Copy full SHA for bcab26d - Browse repository at this point
Copy the full SHA bcab26dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 0042586 - Browse repository at this point
Copy the full SHA 0042586View commit details
Commits on Nov 22, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 44155d0 - Browse repository at this point
Copy the full SHA 44155d0View commit details -
Configuration menu - View commit details
-
Copy full SHA for ffb87a8 - Browse repository at this point
Copy the full SHA ffb87a8View commit details -
Configuration menu - View commit details
-
Copy full SHA for a73b5ae - Browse repository at this point
Copy the full SHA a73b5aeView commit details
Commits on Nov 23, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 1597016 - Browse repository at this point
Copy the full SHA 1597016View commit details
Commits on Nov 27, 2023
-
Configuration menu - View commit details
-
Copy full SHA for f8d3860 - Browse repository at this point
Copy the full SHA f8d3860View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6985a1f - Browse repository at this point
Copy the full SHA 6985a1fView commit details
Commits on Dec 1, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 448634b - Browse repository at this point
Copy the full SHA 448634bView commit details -
Configuration menu - View commit details
-
Copy full SHA for b831295 - Browse repository at this point
Copy the full SHA b831295View commit details
Commits on Dec 3, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 581c34e - Browse repository at this point
Copy the full SHA 581c34eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 66ae553 - Browse repository at this point
Copy the full SHA 66ae553View commit details -
Configuration menu - View commit details
-
Copy full SHA for 18c780c - Browse repository at this point
Copy the full SHA 18c780cView commit details -
Configuration menu - View commit details
-
Copy full SHA for dcb0cd3 - Browse repository at this point
Copy the full SHA dcb0cd3View commit details
Commits on Dec 15, 2023
-
Configuration menu - View commit details
-
Copy full SHA for f624b90 - Browse repository at this point
Copy the full SHA f624b90View commit details -
Configuration menu - View commit details
-
Copy full SHA for d722f03 - Browse repository at this point
Copy the full SHA d722f03View commit details
Commits on Dec 21, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 1d1ad30 - Browse repository at this point
Copy the full SHA 1d1ad30View commit details -
Configuration menu - View commit details
-
Copy full SHA for 38233f2 - Browse repository at this point
Copy the full SHA 38233f2View commit details
Commits on Jan 15, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 6c36d86 - Browse repository at this point
Copy the full SHA 6c36d86View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5990d9d - Browse repository at this point
Copy the full SHA 5990d9dView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.