Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace Turbolinks with Turbo (and upgrade Stimulus) #1181

Merged
merged 26 commits into from
Jan 15, 2024
Merged

Commits on Nov 17, 2023

  1. Configuration menu
    Copy the full SHA
    6c12a3b View commit details
    Browse the repository at this point in the history
  2. Add application.js for stimulus

    derricklannaman authored and jim committed Nov 17, 2023
    Configuration menu
    Copy the full SHA
    f2de076 View commit details
    Browse the repository at this point in the history
  3. Add new files to aid in rendering

    derricklannaman authored and jim committed Nov 17, 2023
    Configuration menu
    Copy the full SHA
    a52946a View commit details
    Browse the repository at this point in the history
  4. Update render and redirect calls as required by Turbo.

    Turbo requires that redirects returned by form submissions have a status of
    303 (see other) so that the browser will follow them with a GET request and
    not use the HTTP method of the submission request. This is semantically
    correct, but a change in behavior from how Rails UJS handled things.
    
    Additionally, Turbo will not render anything when a 200 response is returned
    by a form submission, instead requiring that a 422 (unprocessable entity)
    status is returned in order for it to render the new HTML and its validation
    error messages. This is going to become the Rails default in the future.
    jim committed Nov 17, 2023
    Configuration menu
    Copy the full SHA
    8e18eda View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    f229556 View commit details
    Browse the repository at this point in the history
  6. Rebuild note CRUD using turbo frames.

    There was previously a single controller and set of views that handled
    all note CRUD for both Member and Item. As a part of reworking this
    code, I created separate controllers and views for the notes on each of
    these models. I think this will be eaiser to understand and will allow
    the notes placed on each model to diverge more easily.
    jim committed Nov 17, 2023
    Configuration menu
    Copy the full SHA
    3ee9c02 View commit details
    Browse the repository at this point in the history

Commits on Nov 19, 2023

  1. Configuration menu
    Copy the full SHA
    bcab26d View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    0042586 View commit details
    Browse the repository at this point in the history

Commits on Nov 22, 2023

  1. Configuration menu
    Copy the full SHA
    44155d0 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    ffb87a8 View commit details
    Browse the repository at this point in the history
  3. Delete residual portal code

    jim committed Nov 22, 2023
    Configuration menu
    Copy the full SHA
    a73b5ae View commit details
    Browse the repository at this point in the history

Commits on Nov 23, 2023

  1. Configuration menu
    Copy the full SHA
    1597016 View commit details
    Browse the repository at this point in the history

Commits on Nov 27, 2023

  1. Update devise config for Turbo

    jim committed Nov 27, 2023
    Configuration menu
    Copy the full SHA
    f8d3860 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    6985a1f View commit details
    Browse the repository at this point in the history

Commits on Dec 1, 2023

  1. Configuration menu
    Copy the full SHA
    448634b View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    b831295 View commit details
    Browse the repository at this point in the history

Commits on Dec 3, 2023

  1. Work on fixing system tests.

    jim committed Dec 3, 2023
    Configuration menu
    Copy the full SHA
    581c34e View commit details
    Browse the repository at this point in the history
  2. Fix a few more system tests

    jim committed Dec 3, 2023
    Configuration menu
    Copy the full SHA
    66ae553 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    18c780c View commit details
    Browse the repository at this point in the history
  4. More system test fixes.

    jim committed Dec 3, 2023
    Configuration menu
    Copy the full SHA
    dcb0cd3 View commit details
    Browse the repository at this point in the history

Commits on Dec 15, 2023

  1. Configuration menu
    Copy the full SHA
    f624b90 View commit details
    Browse the repository at this point in the history
  2. Fix a few more tests

    jim committed Dec 15, 2023
    Configuration menu
    Copy the full SHA
    d722f03 View commit details
    Browse the repository at this point in the history

Commits on Dec 21, 2023

  1. Fix standard and erblint errors

    jim committed Dec 21, 2023
    Configuration menu
    Copy the full SHA
    1d1ad30 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    38233f2 View commit details
    Browse the repository at this point in the history

Commits on Jan 15, 2024

  1. Configuration menu
    Copy the full SHA
    6c36d86 View commit details
    Browse the repository at this point in the history
  2. Run erblint

    jim committed Jan 15, 2024
    Configuration menu
    Copy the full SHA
    5990d9d View commit details
    Browse the repository at this point in the history