Replace Turbolinks with Turbo (and upgrade Stimulus) #1181
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Turbo requires that redirects returned by form submissions have a status of 303 (see other) so that the browser will follow them with a GET request and not use the HTTP method of the submission request. This is semantically correct, but a change in behavior from how Rails UJS handled things. Additionally, Turbo will not render anything when a 200 response is returned by a form submission, instead requiring that a 422 (unprocessable entity) status is returned in order for it to render the new HTML and its validation error messages. This is going to become the Rails default in the future.
There was previously a single controller and set of views that handled all note CRUD for both Member and Item. As a part of reworking this code, I created separate controllers and views for the notes on each of these models. I think this will be eaiser to understand and will allow the notes placed on each model to diverge more easily.
jim
force-pushed
the
jim/turbolinks-to-turbo
branch
from
e794d42
to
3ee9c02
Compare
jim
force-pushed
the
jim/turbolinks-to-turbo
branch
from
cf34066
to
44155d0
Compare
phinze
approved these changes
Jan 15, 2024
Closed
jim
added a commit
that referenced
this pull request
Apr 12, 2024
# What it does Fixes #1438 by moving appointments to the appropriate list when the are completed or restored. This feature was originally implemented in dbf9983 but removed in #1181 as a part of the upgrade from Turbolinks to Turbo. # Why it is important Staff have given us feedback that they miss having the app automatically move completed appointments to the list at the bottom of the page without needing a page refresh. # Implementation notes * The new implementation works on both the new and old UI for the appointment list. * `FEATURE_NEW_APPOINTMENTS_PAGE` now defaults to `false` in the test environment (so we can test that the current default is working in tests). We could also write tests for both, but that can be a followup. * I also fixed a bug where completion didn't work properly when `new=true` using a query param. --------- Co-authored-by: Paul Hinze <phinze@phinze.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
Fixes #1184.
Why it is important
Turbolinks is EOLed, and we need to upgrade to Turbo to get back on a supported library. And by using Turbo instead of custom code, we have less to maintain and it's easier for contributors to understand how things work as there are many resources out there for learning Turbo.
Implementation notes
Your bandwidth for additional changes to this PR
Please choose one of the following to help the project maintainers provide the appropriate level of support: