Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build failure with CPython 3.13.0 #25

Open
decaz opened this issue Oct 14, 2024 · 5 comments
Open

Build failure with CPython 3.13.0 #25

decaz opened this issue Oct 14, 2024 · 5 comments

Comments

@decaz
Copy link
Contributor

decaz commented Oct 14, 2024

building 'cyac.xstring' extension
clang++ -fno-strict-overflow -Wsign-compare -Wunreachable-code -DNDEBUG -g -O3 -Wall -Ilib/cyac -I/Users/marat/workspace/publishing/.venv/include -I/Users/marat/.pyenv/versions/3.13.0/include/python3.13 -c lib/cyac/xstring.cpp -o build/temp.macosx-15.0-arm64-cpython-313/lib/cyac/xstring.o
lib/cyac/xstring.cpp:5097:17: error: use of undeclared identifier '_PyUnicode_ToLowerFull'
 5097 |     __pyx_v_n = _PyUnicode_ToLowerFull((__pyx_v_original->chars[__pyx_v_ori_char_idx]), __pyx_v_buf);
      |                 ^
1 error generated.
error: command '/usr/bin/clang++' failed with exit code 1
@decaz
Copy link
Contributor Author

decaz commented Oct 14, 2024

@nppoly @chenkovsky FYI

@chenkovsky
Copy link
Owner

@decaz ACK

@decaz
Copy link
Contributor Author

decaz commented Oct 14, 2024

@chenkovsky previously you suggested to remove support of Python 2, - I think it's time now to do it if it could make this fix be made easier.

@chenkovsky
Copy link
Owner

@chenkovsky
Copy link
Owner

I cannot find these methods in final .so file. so I will copy toLower codes from python as a workaround. python/cpython#117117

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants