-
Notifications
You must be signed in to change notification settings - Fork 497
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
support other arch rather than x86, remove x86 spcified arguments for gc... #98
base: master
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -54,7 +54,7 @@ def __init__(self, options, build_dir, gcc_version, | |
self.version_cpp_compile_template = string.Template(""" | ||
env_version = Environment(ENV = os.environ) | ||
env_version.Append(SHCXXCOMSTR = '%s$updateinfo%s' % (colors('cyan'), colors('end'))) | ||
env_version.Append(CPPFLAGS = '-m$m') | ||
env_version.Append(CPPFLAGS = '$m') | ||
version_obj = env_version.SharedObject('$filename') | ||
""") | ||
self.blade_config = configparse.blade_config | ||
|
@@ -140,9 +140,11 @@ def generate_version_file(self): | |
version_cpp.close() | ||
|
||
self._add_rule('VariantDir("%s", ".", duplicate=0)' % self.build_dir) | ||
|
||
# todo - may not work in python 2.4 | ||
self._add_rule(self.version_cpp_compile_template.substitute( | ||
updateinfo='Updating version information', | ||
m=self.options.m, | ||
m='-m%s' % self.options.m if self.options.arch == 'x86' else '', | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 不要用这种if语句表达式,python 2.4不支持。 There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 的确, 加了一个todo, 不知道有什么比较清爽的写法 There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 没有,只能提到前面 self._add_rule( 2014-04-01 10:38 GMT+08:00 Coney Wu notifications@github.com:
|
||
filename='%s/version.cpp' % self.build_dir)) | ||
|
||
def generate_imports_functions(self, blade_path): | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
我觉得x86_64应该从i386中独立出来
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这里我是这样分的:
arch分x86 arm等, bits分32 64.
所以x86_64是x86 64bit, i386是x86 32bit.
x86上能支持到cmpxchg -32 -64等, 不用再判断等于i386或x86_64,
你觉得怎么样好点?