Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ember-es6-class/no-object-extend rule #447

Open
hmajoros opened this issue May 27, 2020 · 2 comments
Open

ember-es6-class/no-object-extend rule #447

hmajoros opened this issue May 27, 2020 · 2 comments
Labels
enhancement New feature or request

Comments

@hmajoros
Copy link

any reason this chunk isn't using the no-object-extend rule defined here?
https://github.com/scalvert/eslint-plugin-ember-es6-class

this is what our team used to track our native class migration

@scalvert
Copy link
Contributor

Hey @hmajoros, thanks for the issue, and this is a good question.

There's no real reason - we could likely add it to the rest of the rules to ensure we're covering all our bases.

Thanks for the suggestion!

@scalvert scalvert added the enhancement New feature or request label May 27, 2020
@lbdm44
Copy link

lbdm44 commented Jan 4, 2021

@scalvert is there a reason we should be using no-extend-object over the combo of the standard Ember ember/no-classic-classes and ember/no-mixins? Seems like the combination of the two cover the enforcement of ES6 Classes and removing .extend which is only used for mixins at this point.

The only possible corner case I can see is that engineers are using ES6 classes with .extend outside of mixins, but that seems irresponsible considering they should just be using ES6 class extension.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants