From 5d19126709dbe612f7c6f610e0c3801468b735fa Mon Sep 17 00:00:00 2001
From: Chamila Adhikarinayake <cka.adhi@gmail.com>
Date: Wed, 13 Dec 2023 12:19:57 +0530
Subject: [PATCH] Add spotbug exclude file

---
 .../api/devops/RestApiDevopsUtilTest.java     |  2 +-
 pom.xml                                       |  6 ++--
 spotbugs-exclude.xml                          | 31 +++++++++++++++++++
 3 files changed, 35 insertions(+), 4 deletions(-)
 create mode 100644 spotbugs-exclude.xml

diff --git a/components/apimgt/org.wso2.carbon.apimgt.rest.api.devops/src/test/java/org/wso2/carbon/apimgt/rest/api/devops/RestApiDevopsUtilTest.java b/components/apimgt/org.wso2.carbon.apimgt.rest.api.devops/src/test/java/org/wso2/carbon/apimgt/rest/api/devops/RestApiDevopsUtilTest.java
index c0d12d8693e4..27dccf6ae986 100644
--- a/components/apimgt/org.wso2.carbon.apimgt.rest.api.devops/src/test/java/org/wso2/carbon/apimgt/rest/api/devops/RestApiDevopsUtilTest.java
+++ b/components/apimgt/org.wso2.carbon.apimgt.rest.api.devops/src/test/java/org/wso2/carbon/apimgt/rest/api/devops/RestApiDevopsUtilTest.java
@@ -18,7 +18,7 @@
  *
  */
 
-package org.wso2.carbon.apimgt.rest.api.common;
+package org.wso2.carbon.apimgt.rest.api.devops;
 
 import com.fasterxml.jackson.core.JsonProcessingException;
 import java.util.ArrayList;
diff --git a/pom.xml b/pom.xml
index 0ac2049fe240..2d03afa308e7 100644
--- a/pom.xml
+++ b/pom.xml
@@ -300,7 +300,7 @@
                         <xmlOutput>true</xmlOutput>
                         <spotbugsXmlOutputDirectory>${project.build.directory}/spotbugs</spotbugsXmlOutputDirectory>
                         <!--Exclude sources-->
-                        <!--<excludeFilterFile>${maven.spotbugsplugin.exclude.file}</excludeFilterFile>-->
+                        <excludeFilterFile>${maven.spotbugsplugin.exclude.file}</excludeFilterFile>
                     </configuration>
                     <executions>
                         <execution>
@@ -2217,7 +2217,7 @@
         <okio.wso2.version>3.5.0.wso2v1</okio.wso2.version>
 
         <openfeign.version>11.0</openfeign.version>
-        <maven.spotbugsplugin.version>4.1.4</maven.spotbugsplugin.version>
+        <maven.spotbugsplugin.version>4.8.2.0</maven.spotbugsplugin.version>
         <maven.checkstyle.plugin.version>3.0.0</maven.checkstyle.plugin.version>
         <version.checkstyle>8.34</version.checkstyle>
         <org.wso2.orbit.org.mapstruct.version>1.4.1.wso2v1</org.wso2.orbit.org.mapstruct.version>
@@ -2225,7 +2225,7 @@
         <analytics.event.publisher.client.version>1.2.3</analytics.event.publisher.client.version>
         <analytics.event.publisher.client.version.range>[1.0.0,2.0.0)</analytics.event.publisher.client.version.range>
         <org.wso2.orbit.atlassian.oai.version>2.12.1.wso2v2</org.wso2.orbit.atlassian.oai.version>
-        <maven.spotbugsplugin.exclude.file>spotbugs-exclude.xml</maven.spotbugsplugin.exclude.file>
+        <maven.spotbugsplugin.exclude.file>${project.parent.basedir}/../../spotbugs-exclude.xml</maven.spotbugsplugin.exclude.file>
         <skip.aspectj>false</skip.aspectj>
         <javax.jms.version>2.0.1</javax.jms.version>
         <com.damnhandy.version>2.1.6</com.damnhandy.version>
diff --git a/spotbugs-exclude.xml b/spotbugs-exclude.xml
new file mode 100644
index 000000000000..765252b525f0
--- /dev/null
+++ b/spotbugs-exclude.xml
@@ -0,0 +1,31 @@
+<FindBugsFilter>
+    <!-- Ignore negating result of compareTo -->
+    <Match>
+        <Bug pattern="EI_EXPOSE_REP2"/>
+    </Match>
+    <Match>
+        <Bug pattern="EI_EXPOSE_REP"/>
+    </Match>
+
+        
+        <Match>
+        <Bug pattern="UWF_FIELD_NOT_INITIALIZED_IN_CONSTRUCTOR"/>
+    </Match>
+    <Match>
+        <Bug pattern="CT_CONSTRUCTOR_THROW"/>
+    </Match>
+    
+        <Match>
+        <Bug pattern="PA_PUBLIC_PRIMITIVE_ATTRIBUTE"/>
+    </Match>
+    <Match>
+        <Bug pattern="URF_UNREAD_FIELD"/>
+    </Match>
+        <Match>
+        <Bug pattern="MS_EXPOSE_REP"/>
+    </Match>
+
+        <Match>
+        <Bug pattern="URF_UNREAD_PUBLIC_OR_PROTECTED_FIELD"/>
+    </Match>
+</FindBugsFilter>
\ No newline at end of file