Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

transition's routing types should not depends on osrm #1115

Open
greenscientist opened this issue Nov 26, 2024 · 1 comment
Open

transition's routing types should not depends on osrm #1115

greenscientist opened this issue Nov 26, 2024 · 1 comment

Comments

@greenscientist
Copy link
Collaborator

Currently we have type that contains route data that depends on OSRM:

export interface transitionMatchOptions extends osrm.MatchOptions {
    mode: RoutingMode;
    points: GeoJSON.Feature<GeoJSON.Point>[];
}
 
export interface transitionRouteOptions extends osrm.RouteOptions {
    mode: RoutingMode;
    points: GeoJSON.Feature<GeoJSON.Point>[];
}

Those transition*options type should not depends on OSRM. We might want to support other engine like valhalla, so those results container should be engine agnostic.

@greenscientist
Copy link
Collaborator Author

(We could get rid of an import for types/osrm with this, as discussed in #1114 )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant