Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

data_apko_tags doesn't respect apk provides #377

Open
wlynch opened this issue Sep 17, 2024 · 0 comments
Open

data_apko_tags doesn't respect apk provides #377

wlynch opened this issue Sep 17, 2024 · 0 comments

Comments

@wlynch
Copy link
Member

wlynch commented Sep 17, 2024

Currently, data_apko_tags uses a prefix-match to determine matching packages. This works for matching things like foo vs foo-fips.

if strings.HasPrefix(pkg, data.TargetPackage.ValueString()+"-") {

However, this doesn't work if packages are not strict prefixes of each other - e.g. foo-bar vs foo-fips-bar. Normally packages would represent this kind of "foo with bar variant" with a provides section of the apk, but the provider only considers the apko config itself during resolution.

Ideally, the following apk pkginfo should be able to satisfy foo:

name = bar
provides = foo
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant