Add outbound tracking on links #1928
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for ornate-narwhal-088216 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Signed-off-by: Patrick Smyth <patrick.smyth@chainguard.dev>
Signed-off-by: Patrick Smyth <patrick.smyth@chainguard.dev>
|
Added these links to our rumble comparison pages: |
amouat
approved these changes
Nov 25, 2024
| @@ -238,7 +238,7 @@ assume-and-explore: | |||
|
|
|||
| Let's go over what this configuration does. | |||
|
|
|||
| First, GitLab requires that pipelines have a shell. To this end, this configuration uses the [`cgr.dev/chainguard/wolfi-base` image](https://images.chainguard.dev/directory/image/wolfi-base/overview) since it includes the `sh` shell. | |||
| First, GitLab requires that pipelines have a shell. To this end, this configuration uses the [`cgr.dev/chainguard/wolfi-base` image](https://images.chainguard.dev/directory/image/wolfi-base/overview?utm_source=cg-academy&utm_medium=website&utm_campaign=dev-enablement&utm_content=chainguard/administration/iam-organizations/identity-examples/gitlab-identity) since it includes the `sh` shell. | |||
There was a problem hiding this comment.
can you check if /s are allowed? I think they might break it and need escaped
There was a problem hiding this comment.
Yeah that checks out. I'll replace them with hyphens. They don't need to be machine readable anyway.
There was a problem hiding this comment.
I looked it up out of curiosity. You shouldn't use :/?#[]@!$&'()*+,;=. Hyphen is fine.
|
On pause while I get a little review on the utm fields |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adding outbound tracking on links to our main CTAs, such as links to the images directory.
Reviewing
I ran a script that uses regex, it would be good to check for edge cases. I'll also do a few manual edits, I'll keep those in separate commits. The commit name will show if it's manual or automated.
Notes
I added a content field so we know what page is generating the outbound link in analytics. I've done some stuff so that it's not a useless path like "index".
References https://github.com/chainguard-dev/internal/issues/4233
cc @sheesh @ltagliaferri @SharpRake