Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New SauceLabs EU Data Center #21

Open
xray5483 opened this issue Mar 6, 2019 · 4 comments
Open

New SauceLabs EU Data Center #21

xray5483 opened this issue Mar 6, 2019 · 4 comments

Comments

@xray5483
Copy link

xray5483 commented Mar 6, 2019

Hi there,
A few days back SauceLabs have inaugurated their new EU Data Centre in Frankfurt. In order to switch to it there are some changes that need to be performed within the sauceclient.py file like:

self.apibase = apibase or 'eu-central-1.saucelabs.com'

and

def get_job_asset_url(self, job_id, filename):
"""Get details about the static assets collected for a specific job."""
return 'https://eu-central-1.saucelabs.com/rest/v1/{}/jobs/{}/assets/{}'.format(
self.client.sauce_username, job_id, filename)

I didn't have push access to propose the update as part of a new branch / pull request thus raised it as an issue!

Please have a look at this page for the new details provided by SauceLabs here

Regards,
Ray

@cgoldberg
Copy link
Owner

Thanks for notifying me. I can make these changes if you'd like. However, you could also use this as an opportunity to learn open source development. It's easy to participate!

I didn't have push access to propose the update as part of a new branch / pull request

You don't need push access to my repo to submit a Pull Request.

Follow these steps:

  • fork my repo on GitHub (this makes a copy of my repo that belongs to you)
  • clone a local copy of the repo from your fork
  • create a branch in your local repo
  • make your modifications and commit the changes
  • push the changes back to a branch in your repo
  • go to GitHub and create a Pull Request from your branch into my [upstream] repo

Once you submit the Pull Request, I will either accept the Pull Request as-is, or I will request that you make changes to your branch. Once satisfied, I will merge the Pull Request (adding the commits from your branch to my repo's master branch).

for more details, see: https://help.github.com/en/articles/creating-a-pull-request-from-a-fork

Thanks!

@cgoldberg
Copy link
Owner

bump

@LasseHall
Copy link

@cgoldberg my understanding is that the current implementation of apibase on master is enough for the use of EU DC. My only problem is that PyPI doesn't have a release with the relevant commit so I have to use an awkward -e git+https://github.com/cgoldberg/sauceclient.git#egg=sauceclient in requirements of my python project.

Can you create a release in PyPI?

@dshuga
Copy link

dshuga commented Aug 9, 2021

Can you create a release in PyPI?

Bump

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants