CMS: add pileup info to the lumi records #3689
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good to me. The only suggestion I would make is to perhaps squash your commits into one. |
tpmccauley
approved these changes
Oct 26, 2024
|
@tpmccauley I think the squashing can be done in the merge... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While adding instructions about pileup reweighting to the CMS open data guide I realized we don't have the necessary input information on the lumi records. This PR adds one extra lumi JSON file to the 2011, 2012, and 2015 records. No changes to the existing files! We can discuss whether it would be better to make a new record, but this feels simpler.
The necessary files are: /eos/opendata/cms/...
I left dummies for the checksum & file size. I incremented the number of files, but didn't change the overall file size for the record. Each record gets a new sentence in the description: "Condensed information about the instantaneous luminosity by lumi section needed to determine the uncertainty in the pileup prediction is provided in the file."
Corresponding pointer in our pileup guide to the Open Data Guide page where the pileup reweighting will be discussed. The content for that page is here, but I haven't pushed that on yet since the links to the portal are likely to fail right now. It can follow this very quickly so there's no significant time with a link to an "under construction" page.